Make variable types clearer to static analysis tools

TypeHints

Fix error when editing account details an no tree exists

Remove View:share() - it's just a global

Fix: #2706 - Break EditGedcomRecordController into request handlers

Fix: #2705 - Break EditGedcomRecordController into request handlers

Rewrite error handler - #2686 and #2685

Fix: #2672 - default redirect after login

Use flash messages for authentication failure

Remove dependency on UserInterface

Generator for robots.txt

Remove global constant WT_LOCALE and store LocaleInterface in the request

No need to throw exceptions in assert()

Fix: #2691 - Routing for account edit/delete

Fix: #2644 - Refactor site logs controller to use service and request handlers

DeadCode

Refactor pending changes to use service and request handlers

Scrutinizer Auto-Fixes (#2683)

This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com

Fix; #2664 - Refactor reports to use POST/GET and request handlers

Fix: #2668 route 'home-page' now has a request handler

Use tree service

Static analysis tools dislike variable method calls.

Strict types

Prune dead code

Fix: #2665 - Use POST+GET on search forms