ScreenSaver prefs: Invoke list item runs test

This copies the behavior of BeOS R5 ScreenSaver prefs.

Don't invoke the listview on AllAttached() anymore, this would make
the selected screensaver sta

ScreenSaver prefs: Invoke list item runs test

This copies the behavior of BeOS R5 ScreenSaver prefs.

Don't invoke the listview on AllAttached() anymore, this would make
the selected screensaver start when the pref window opens.

Horizontally center the Test button.

Change-Id: I65471112d37d9efd17945f05bce485ff2fece9dd
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1958
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

show more ...

PVS V595: Pointer was utilized before it was verified against nullptr.

Change-Id: Iba8b7e6160dc237f45080fa7c101fa72e4d8c753
Reviewed-on: https://review.haiku-os.org/c/1643
Reviewed-by: waddlesplash

PVS V595: Pointer was utilized before it was verified against nullptr.

Change-Id: Iba8b7e6160dc237f45080fa7c101fa72e4d8c753
Reviewed-on: https://review.haiku-os.org/c/1643
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

show more ...

ScreenSaver: add live update of screensavers list.

Fixes #13956

Change-Id: Icfc26c1617541f030ece31d36f1e3bb0c2ec96b0

ScreenSaver: Center window on screen

Screensaver: Set explicit min width for fSettingsView

Also make some new const variables to make some math more opaque
i.e. don't use as many magic constants.

This works great at 12pt font size, de

Screensaver: Set explicit min width for fSettingsView

Also make some new const variables to make some math more opaque
i.e. don't use as many magic constants.

This works great at 12pt font size, decenly at all other sizes. There is a
bit of jitter at 13pt and 24pt for some reason when moving from a default
settings view to another settings view.

show more ...

Screensaver: Move Puck up alphabetically

Screensaver: Blackness not Darkness

ScreenSaver: Rename BuildScreenSaverDefaultSettingsView

...to just DefaultSettingsView

It is just as obvious what it does in context, but shorter.

Rename the function it contains from
BuildDefault

ScreenSaver: Rename BuildScreenSaverDefaultSettingsView

...to just DefaultSettingsView

It is just as obvious what it does in context, but shorter.

Rename the function it contains from
BuildDefaultScreenSaverSettingsView to
BuildDefaultSettingsView

show more ...

Merge remote-tracking branch 'upstream/master' into intel-extreme

preferences: Convert to using Set*UIColor.

Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
Patches 0023-0037 from looncraz, unmodified.

Merge remote-tracking branch 'upstream/master' into intel-extreme

When testing screensaver, don't have mouse move exit the screen saver.

Fixes #7463

Signed-off-by: Adrien Destugues <pulkomandy@gmail.com>

Move time formatting to BTimeformat.

* Harmonize API for all B*Format to take an output BString by reference
as the first parameter,
* Move the FormatTime methods from BLocale to BTimeFormat
* Adjus

Move time formatting to BTimeformat.

* Harmonize API for all B*Format to take an output BString by reference
as the first parameter,
* Move the FormatTime methods from BLocale to BTimeFormat
* Adjust all callers for BTimeFormat, BTimeUnitFormat and
BDurationFormat.

show more ...

ScreenSaver: rework some of the fixes

* Use a BTextView for the "no preview" text again, as Skipp_OSX pointed
this allows it to word wrap as needed with any font bigger than 10pt.
* Show a black scr

ScreenSaver: rework some of the fixes

* Use a BTextView for the "no preview" text again, as Skipp_OSX pointed
this allows it to word wrap as needed with any font bigger than 10pt.
* Show a black screen rather than the "no preview" text for Darkness and
when a screensaver fails to load. This matches what screen_blanker will
do.

show more ...

Make the "no preview" screen work in all cases

* HideNoPreview() was never called...
* Use a BCardLayout to make it easier to know which of the two screens
is shown.

Make ScreenSaver preferences work again.

This reverts 0fb019bbf21e791ae1f7644652fea3697b3f3d9f. Making the window
a BDirectWindow isn't a good idea, especially if you want things other
than a direct

Make ScreenSaver preferences work again.

This reverts 0fb019bbf21e791ae1f7644652fea3697b3f3d9f. Making the window
a BDirectWindow isn't a good idea, especially if you want things other
than a direct rendering view in it. Moreover, this is completely
unneeded as GL works just as well in non-direct mode.

show more ...

include strings.h where appriopriate...

instead or additionally to string.h, in preparation for functions move.
* moves str[n]casecmp() functions and others to strings.h.
* strings.h doesn't include

include strings.h where appriopriate...

instead or additionally to string.h, in preparation for functions move.
* moves str[n]casecmp() functions and others to strings.h.
* strings.h doesn't include string.h anymore.
* this solves #10949

show more ...

ScreenSaver: use stack variable to prevent memory leak

ScreenSaver: Stop saver on General tab.

Unfortunately OpenGL screen saver previews draw on top of the tabview,
so, when you switch to the General tab we now stop the screen saver
and then restart it

ScreenSaver: Stop saver on General tab.

Unfortunately OpenGL screen saver previews draw on top of the tabview,
so, when you switch to the General tab we now stop the screen saver
and then restart it when you come back to the Screensavers tab.

show more ...

ScreenSaver: Add "No preview available" text

... when a screensaver doesn't provide a preview.

Also do a bit of refactoring in PreviewView, remove unneeded includes

ScreenSaver: Refactor ModulesView

Create controls in initializer list of constructor, delete controls in
the (newly-added) destructor.

Make fSettings the first private member.

ScreenSaver: pass in true to get a preview

Fixes #10602

This was a simple mistake on my part, unfortunately this means that
a bunch of screen savers that showed preview fine before no longer do.

ScreenSaver: check function return values for success

Screensaver: Convert Screensaver to a BDirectWindow

This allows OpenGL screensavers to be able to show a preview.

Removed function to add screensavers

Removed "Add..." button and drag&drop awareness, as discussed in
http://www.freelists.org/post/haiku-development/Adding-screensavers-and-fonts
In short: all apps

Removed function to add screensavers

Removed "Add..." button and drag&drop awareness, as discussed in
http://www.freelists.org/post/haiku-development/Adding-screensavers-and-fonts
In short: all apps and add-ons will come as proper hpkg.

show more ...