Merge remote-tracking branch 'origin/master' into dev/netservices

Change-Id: I588c4a840523995f820161d63741c137bc5c719c

StyledEdit: Add comment explaining MakeFocus() loc

... to explain hrev562209 by Jim906 which fixes #17733
StyledEdit: give initial focus to the TextView

No functional change

Change-Id: Id428290d8d

StyledEdit: Add comment explaining MakeFocus() loc

... to explain hrev562209 by Jim906 which fixes #17733
StyledEdit: give initial focus to the TextView

No functional change

Change-Id: Id428290d8d3530e5ef9213489625c1968984d323
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5422
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: nephele <nep@packageloss.eu>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

show more ...

StyledEdit: give initial focus to the TextView

* Move the existing MakeFocus call to after the window layout is built.
* Also, add calls to Activate so that StyledEdit becomes the active
window af

StyledEdit: give initial focus to the TextView

* Move the existing MakeFocus call to after the window layout is built.
* Also, add calls to Activate so that StyledEdit becomes the active
window after its find or replace window is closed/hidden, even if
another application is set to 'always on top.'
* Fixes #17733.

Change-Id: I8380e8ce2760ffa3f3467a618a0d843826e4ac99
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5416
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: humdinger <humdingerb@gmail.com>
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>

show more ...

StyledEdit: add menu to underline text

Eases testing of B_UNDERSCORE_FACE

Change-Id: If3e1f247a984b81e9262136ca30139851cfa19a2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4244
Tested-by: Com

StyledEdit: add menu to underline text

Eases testing of B_UNDERSCORE_FACE

Change-Id: If3e1f247a984b81e9262136ca30139851cfa19a2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4244
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

show more ...

StyledEdit: SetInsets() instead of insetting initial text rect

Initial rect size doesn't persist to changing text rect sizes and
alignment changes but insets do. Maintains a 3px border around text
o

StyledEdit: SetInsets() instead of insetting initial text rect

Initial rect size doesn't persist to changing text rect sizes and
alignment changes but insets do. Maintains a 3px border around text
on all sides.

Change-Id: I70e855c3b6b17bc576fd5e38cd43fedb6c830aef
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3901
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

show more ...

StyledEdit: fix replace menu item

Regression after hrev54812.

Change-Id: I5f8e06c5b161eb859afc7f03b08e1c0cb07a99d0
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3604
Reviewed-by: humdinger <hu

StyledEdit: fix replace menu item

Regression after hrev54812.

Change-Id: I5f8e06c5b161eb859afc7f03b08e1c0cb07a99d0
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3604
Reviewed-by: humdinger <humdingerb@gmail.com>

show more ...

StyledEdit: fix layout

Fixes #16721.

Change-Id: I1ab1489b5cfe6ae0fce4ba1de9d14c69685e5a65
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3603
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

StyledEdit: Fix New menu item after hrev54812

Change-Id: I583bc43dc64d46e92e20e46da9a894c489617d43
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3563
Reviewed-by: waddlesplash <waddlesplash@gma

StyledEdit: Fix New menu item after hrev54812

Change-Id: I583bc43dc64d46e92e20e46da9a894c489617d43
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3563
Reviewed-by: waddlesplash <waddlesplash@gmail.com>

show more ...

StyledEdit: convert main view to layout api

Change-Id: I913c8f559faf09654b0e249f512858ed24fe1ffe
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3537
Reviewed-by: John Scipione <jscipione@gmail.c

StyledEdit: convert main view to layout api

Change-Id: I913c8f559faf09654b0e249f512858ed24fe1ffe
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3537
Reviewed-by: John Scipione <jscipione@gmail.com>

show more ...

IK: align BTextView text rect/fix alignment

Recalculate line breaks in FrameResized() if word-wrap is on, otherwise
only move the text rect into position. StyledEdit was recalculating line
breaks be

IK: align BTextView text rect/fix alignment

Recalculate line breaks in FrameResized() if word-wrap is on, otherwise
only move the text rect into position. StyledEdit was recalculating line
breaks before on resize (we have to in this mode) and the frame offset
updates for non-wrapping text views are inexpensive. This makes resizing
text view's work like StyledEdit everywhere.

Scroll to cursor when word-wrap setting changes if text view is editable.
If you are viewing a long document changing word-wrap can move the cursor
quite far, so scroll back to it.

Fix _ActualTabWidth() pen location for right and center-aligned text views
so that tabs widths are calculated correctly.

Reset fTextRect horizontal limits to bounds minus insets in
_RecalculateLineBreaks(), then grow fTextRect based on alignment when
wrap is off.

Fixing insets also fixes right and center-aligned BTextViews.
Left-aligned text view's grow right, right-aligned ones grow left,
and center-aligned ones grow out.

Make extra scrolling space for all aligned text views go the other way
from how it did in hrev24130 (and on left-aligned text view's too) so
that half the text is visible when you edit past the end or before the
beginnning of a text view instead of none of it.

Fixes #1651 #12608 #13796 #15189

Do not _RecalculateLineBreaks() if text view bounds are invalid.
In SetText() detect invalid text view bounds and resize the view to the
width and height of the first line. Then recalculate line breaks.
This fixes BAlert text view size issues.

Fixes #16481 (regression from hrev54496.)

Remove useless and heavy computation. There is no point in computing line
breaks for a 10px wide text view and it takes a long time because it needs
a lot of linebreaks. The view eventually gets laid out properly.

Fixes #5582 (which was not locale-related, after all.)

Only apply default insets if text rect is set to bounds. This ensures
that apps that manipulate the text rect can continue to do so without
the default insets interfering while apps that don't can benefit
from the defaults. If you want to set the text rect to bounds and
not use the default insets you must override the default by calling
SetInsets(). This prevent the default insets from being applied once
apps have changed the text rect fixing a bug in Icon-O-Matic where the
text rect insets were being applied incorrectly.

Fixes #16488 (regression from hrev54496.)

Reduce left and right insets inside text views from full label spacing
to half label spacing. Unify padding between BTextControl and BTextView.

Move fLayoutData->UpdateInsets() to private BTextView::_UpdateInsets()
because we need access to BTextView member variables when deciding
whether or not to add the default padding or not.

_UpdateInsets() changes:
* Don't update insets if BTextView::SetInsets() was called.
* Don't add default insets unless fTextRect is set to view Bounds().
* Do not set the right and bottom insets to left and top if negative,
set them to 0 like we do to left and top -- DeskCalc bug otherwise.

Fixes #15688

Other BTextView fixes:
* Replace max_c and min_c with std::max and std::min respectively.
* Remove scrolling from one instance of BTextView::SetText() as it
produced undesired results while editing a scrolled text view.
* Add default insets in _UpdateInsets()
* Fix scrolling when entering and deleting text so that some part of
the text is always visible. Make visible scroll width depend on font
size.
* Allow scrolling to a negative offset in x but not y. This allows you
to scroll the entire contents of right and centered-aligned text views
whose content does not fit in the box.
* Change _Refresh() to take an offset instead of a bool so that you can
scroll to any offset.
* Replace TextLength() with fText->Length() in a couple of places.

TextControl changes:
* Set text rect in BTextControl::DoLayout().
* Remove AlignTextRect() from TextInput.

Fix the following problems in apps:

ScreenSaver: Set text rect in PreviewView::AddPreview().
Tracker: Set "Edit name" text view insets to 2. Tweek text rect position
to be on top of label in icon, mini-icon, and list mode. Add a TODO that
the text rect is a pixel off from the name on some files.
Mail: Remove _AlignTextRect() and FrameResized() from AddressTextControl.
Use default insets on the text view, defaults are fine here.
DeskCalc: Set insets based on font size in ExpressionTextView
SetTextRect() instead of manipulating the text rect.
Remove _CheckTextRect() and related methods from InputTextView.
Icon-O-Matic: Remove _CheckTextRect() and related methods from InputTextView.
WebPositive: Remove _AlignTextRect() and FrameResized() from URLTextView
and call SetInsets().
StyledEdit: Word-wrap and FrameResized() changes ported to BTextView.

Fixes #16476 #16480 #16488 (regressions from hrev54496.)

Change-Id: Ifeca6077f8815ccd86d5a3880f99556298aaf0fe
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3152
Reviewed-by: John Scipione <jscipione@gmail.com>

show more ...

StyledEdit: Fix build after previous changes.

StyledEdit: Add cmd +, cmd - shortcuts for font size

Change-Id: I540ed130322fa1ce7eba62c4a1d1de36b12ccf9a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2303
Reviewed-by: Adrien Destugues <pulko

StyledEdit: Add cmd +, cmd - shortcuts for font size

Change-Id: I540ed130322fa1ce7eba62c4a1d1de36b12ccf9a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2303
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>

show more ...

StyledEdit: Fix PVS 1167

Use new(std::nothrow) so that NULL check for allocated memory makes sense.

Change-Id: I6c0e66c63adda430686727a4085132c4e40c7530
Reviewed-on: https://review.haiku-os.org/692

StyledEdit: Fix PVS 1167

Use new(std::nothrow) so that NULL check for allocated memory makes sense.

Change-Id: I6c0e66c63adda430686727a4085132c4e40c7530
Reviewed-on: https://review.haiku-os.org/692
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>

show more ...

StyledEdit: avoid crash on replace window

* Fixes #13842

StyledEdit: Rework of the font color system

1) The default font color is now B_DOCUMENT_TEXT_COLOR
2) The font color menu now shows a palette
3) The font color menu now includes a "default" item, se

StyledEdit: Rework of the font color system

1) The default font color is now B_DOCUMENT_TEXT_COLOR
2) The font color menu now shows a palette
3) The font color menu now includes a "default" item, set
to B_DOCUMENT_TEXT_COLOR
4) Added a Todo mentionning it would be ideal to not save the default color
itself, but instead saving the fact the default color was used. Maybe allow the
StyleBuffer to use a Null color or something similar.

show more ...

StyledEdit: add navigation menu to status bar.

* Fix #12099.

StyledEdit: ensure caret position gets set correctly

* When opening documents without be:caret_position,
StyledEdit would place the cursor at the end of
the file. _LoadAttrs() intended to set it

StyledEdit: ensure caret position gets set correctly

* When opening documents without be:caret_position,
StyledEdit would place the cursor at the end of
the file. _LoadAttrs() intended to set it to the
beginning; however, a check for an existing BRect
for positioning the window would return early,
preventing the caret position to be set.

Fixes #11463

show more ...

Make sure there's a space in front of B_UTF8_ELLIPSIS.

As PulkoMandy said in hrev47388: C++11 safe and reads better.

StyledEdit: Fix #10349.

Override QuitRequested in FindWindow to notify the parent edit window of the
find window's demise so it can reset its corresponding pointer. Otherwise the
latter will potenti

StyledEdit: Fix #10349.

Override QuitRequested in FindWindow to notify the parent edit window of the
find window's demise so it can reset its corresponding pointer. Otherwise the
latter will potentially access the invalid pointer in question on subsequent
find requests, leading to potential crashes.

show more ...

StyleEdit: non-modal Find/Replace windows implementation

* Switch to non-modal floating windows for Find/Replace dialogs,
preserve parameters of the previous search in this editor session;
* Fixes

StyleEdit: non-modal Find/Replace windows implementation

* Switch to non-modal floating windows for Find/Replace dialogs,
preserve parameters of the previous search in this editor session;
* Fixes #10053.

- GCI 2013

show more ...

StyledEdit: Use RecentItems helper instead of private impl.

* Switch recent documents list to use RecentItems.h helper instead of
homebrewn implementation;
* Fixes #9999.

- GCI 2013

StyledEdit:update status view after document was saved

Merge branch 'master' into sam460ex

Merge remote-tracking branch 'haiku/master' into package-management

This reverts 8f7f28a7c3db28711920ad5d15df401fae90bcf1 (OpenGL: Upgrade
to
Mesa 9.2).

Conflicts:
build/jam/BuildFeatures
build/j

Merge remote-tracking branch 'haiku/master' into package-management

This reverts 8f7f28a7c3db28711920ad5d15df401fae90bcf1 (OpenGL: Upgrade
to
Mesa 9.2).

Conflicts:
build/jam/BuildFeatures
build/jam/HaikuImage
build/jam/OptionalPackages
build/scripts/build_cross_tools_gcc4
src/add-ons/opengl/swpipe/Jamfile
src/apps/diskusage/Jamfile
src/kits/tracker/ContainerWindow.cpp
src/kits/tracker/DeskWindow.cpp
src/kits/tracker/Jamfile

show more ...

StyledEdit:supress unlock if the file is on RO volume

Show the "Read-only" status for documents that are living on read-only
volumes and do not show unlock menu for such files.

* The enhancement po

StyledEdit:supress unlock if the file is on RO volume

Show the "Read-only" status for documents that are living on read-only
volumes and do not show unlock menu for such files.

* The enhancement pointed out by Sergei Reznikov (Diver). Thanks!

show more ...