Searched hist:a4436289742fa0cd898736b78bcd096e0cb5bc6c (Results 1 – 4 of 4) sorted by relevance
| /haiku/src/add-ons/media/plugins/au_reader/ |
| H A D | au_reader.cpp | a4436289742fa0cd898736b78bcd096e0cb5bc6c Wed Dec 21 13:06:04 UTC 2022 PulkoMandy <pulkomandy@pulkomandy.tk> media plugins: replace strcpy with strlcpy
Fixes a memory corruption: the ffmpeg plugin has a LOT of file
extensions, which goes way past the 8 allowed characters and even past
the 88 reserved bytes at the end of the structure. As a result, memory
after the structure is overwritten, resulting in heap corruption and
crashes.
This is immediately detected by using the guarded heap.
As a short term measure, use strlcpy to avoid overwriting memory, but
now the ffmpeg plugin will be unable to provide any useful info. It
would make sense to make media_format_info store a pointer to a string
instead (similar to entry_ref), but this requires more changes and will
create some incompatibility with existing apps if they use the field.
Change-Id: I8d2b567a179e9f7816b72f48aedac4e8534bc044
|
| /haiku/src/add-ons/media/plugins/ape_reader/ |
| H A D | APEReader.cpp | a4436289742fa0cd898736b78bcd096e0cb5bc6c Wed Dec 21 13:06:04 UTC 2022 PulkoMandy <pulkomandy@pulkomandy.tk> media plugins: replace strcpy with strlcpy
Fixes a memory corruption: the ffmpeg plugin has a LOT of file
extensions, which goes way past the 8 allowed characters and even past
the 88 reserved bytes at the end of the structure. As a result, memory
after the structure is overwritten, resulting in heap corruption and
crashes.
This is immediately detected by using the guarded heap.
As a short term measure, use strlcpy to avoid overwriting memory, but
now the ffmpeg plugin will be unable to provide any useful info. It
would make sense to make media_format_info store a pointer to a string
instead (similar to entry_ref), but this requires more changes and will
create some incompatibility with existing apps if they use the field.
Change-Id: I8d2b567a179e9f7816b72f48aedac4e8534bc044
|
| /haiku/src/add-ons/media/plugins/raw_decoder/ |
| H A D | RawDecoderPlugin.cpp | a4436289742fa0cd898736b78bcd096e0cb5bc6c Wed Dec 21 13:06:04 UTC 2022 PulkoMandy <pulkomandy@pulkomandy.tk> media plugins: replace strcpy with strlcpy
Fixes a memory corruption: the ffmpeg plugin has a LOT of file
extensions, which goes way past the 8 allowed characters and even past
the 88 reserved bytes at the end of the structure. As a result, memory
after the structure is overwritten, resulting in heap corruption and
crashes.
This is immediately detected by using the guarded heap.
As a short term measure, use strlcpy to avoid overwriting memory, but
now the ffmpeg plugin will be unable to provide any useful info. It
would make sense to make media_format_info store a pointer to a string
instead (similar to entry_ref), but this requires more changes and will
create some incompatibility with existing apps if they use the field.
Change-Id: I8d2b567a179e9f7816b72f48aedac4e8534bc044
|
| /haiku/src/add-ons/media/plugins/ffmpeg/ |
| H A D | AVFormatReader.cpp | a4436289742fa0cd898736b78bcd096e0cb5bc6c Wed Dec 21 13:06:04 UTC 2022 PulkoMandy <pulkomandy@pulkomandy.tk> media plugins: replace strcpy with strlcpy
Fixes a memory corruption: the ffmpeg plugin has a LOT of file
extensions, which goes way past the 8 allowed characters and even past
the 88 reserved bytes at the end of the structure. As a result, memory
after the structure is overwritten, resulting in heap corruption and
crashes.
This is immediately detected by using the guarded heap.
As a short term measure, use strlcpy to avoid overwriting memory, but
now the ffmpeg plugin will be unable to provide any useful info. It
would make sense to make media_format_info store a pointer to a string
instead (similar to entry_ref), but this requires more changes and will
create some incompatibility with existing apps if they use the field.
Change-Id: I8d2b567a179e9f7816b72f48aedac4e8534bc044
|